[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gawk] [gawk-diffs] [SCM] gawk branch, gawk-4.0-stable, updated.
From: |
Stefano Lattarini |
Subject: |
Re: [bug-gawk] [gawk-diffs] [SCM] gawk branch, gawk-4.0-stable, updated. |
Date: |
Fri, 21 Oct 2011 15:48:26 +0200 |
User-agent: |
KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) |
Hi Arnold.
On Friday 21 October 2011, Arnold Robbins wrote:
> http://git.sv.gnu.org/cgit/gawk.git/commit/?id=3b5e1a089dc3f1193ddc73747524aa24fcab3899
>
> commit 3b5e1a089dc3f1193ddc73747524aa24fcab3899
> Author: Arnold D. Robbins <address@hidden>
> Date: Fri Oct 21 15:01:08 2011 +0200
>
> Fix 'make distcheck' to not kvetch about version.c.
>
> diff --git a/ChangeLog b/ChangeLog
> index 1fa930c..887ac71 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2011-10-21 Arnold D. Robbins <address@hidden>
> +
> + * Makefile.am (distcleancheck_listfiles): Added, per advice from
> + Stefano Lattarini <address@hidden>.
> +
> 2011-10-21 Stefano Lattarini <address@hidden>
>
> * configure.ac (AM_C_PROTOTYPES): Remove call to this macro.
> diff --git a/Makefile.am b/Makefile.am
> index 13ba6bd..4a1340a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -114,6 +114,8 @@ gawk_SOURCES = $(base_sources) eval.c profile.c
> pgawk_SOURCES = $(base_sources) eval_p.c profile_p.c
> dgawk_SOURCES = $(base_sources) eval_d.c profile.c cmd.h command.y debug.c
>
> +distcleancheck_listfiles = version.c
> +
This usage is wrong: $(distcleancheck_listfiles) is intended to be a
*command* that gets executed by the recipe of the `distcleancheck'
target to get a list of all files that should *not* be present in
the builddir after a "make distclean" (see the automake manual for
examples). What you want is something like this (untested!):
distcleancheck_listfiles = find . -type f -print | grep -v '^\./version\.c$'
> # Get extra libs as needed, Automake will supply LIBINTL and SOCKET_LIBS.
> LDADD = $(LIBSIGSEGV) $(LIBINTL) $(SOCKET_LIBS)
> dgawk_LDADD = $(LDADD) @LIBREADLINE@
> diff --git a/Makefile.in b/Makefile.in
> index c06dac6..db5c2ae 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -173,7 +173,6 @@ am__relativize = \
> DIST_ARCHIVES = $(distdir).tar.gz $(distdir).tar.xz
> GZIP_ENV = --best
> distuninstallcheck_listfiles = find . -type f -print
>
In fact, it makes little sense to substitute ...
> -distcleancheck_listfiles = find . -type f -print
>
... this ...
> @@ -387,6 +386,7 @@ base_sources = \
> gawk_SOURCES = $(base_sources) eval.c profile.c
> pgawk_SOURCES = $(base_sources) eval_p.c profile_p.c
> dgawk_SOURCES = $(base_sources) eval_d.c profile.c cmd.h command.y debug.c
> +distcleancheck_listfiles = version.c
>
... with this.
Sorry if I had been unclear in my previous suggestion :-(
Hope I've made it up for it now.
Regards,
Stefano
- Re: [bug-gawk] [gawk-diffs] [SCM] gawk branch, gawk-4.0-stable, updated.,
Stefano Lattarini <=