Re: [bug-gawk] Inconsistent External Command Spawning

[Eli Zaretskii]

> Date: Sat, 22 Jun 2013 21:32:08 -0700 (PDT)
> From: David Millis <address@hidden>
> Cc: "address@hidden" <address@hidden>
> 
> G:\>gawk410 -f exec_test.txt
> System
> xx
> 
> Pipe
> x%1x
> 
> G:\>gawk401 -f exec_test.txt
> System
> xx
> 
> Pipe
> xx
> - - -
> 0.o
> 
> Sanity Check: Do your builds do this?

Yes, sorry.  And I found out why.  A change made in preparation for
Gawk 4.1.0 inadvertently moved the inclusion of popen.h to a portion
of io.c that is not compiled by MinGW.  Thus, the redirection of popen
to os_popen did not happen, and the rest is history.

Here's the patch to fix that:

--- io.c~1      2013-05-14 14:55:51.338000000 +0300
+++ io.c        2013-06-23 18:13:16.729020700 +0300
@@ -76,10 +76,6 @@
 #include <netdb.h>
 #endif /* HAVE_NETDB_H */
 
-#if defined(HAVE_POPEN_H)
-#include "popen.h"
-#endif
-
 #ifndef HAVE_GETADDRINFO
 #include "missing_d/getaddrinfo.h"
 #endif
@@ -108,6 +104,10 @@
 #include <limits.h>
 #endif
 
+#if defined(HAVE_POPEN_H)
+#include "popen.h"
+#endif
+
 #ifdef __EMX__
 #include <process.h>
 #endif