[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] [PATCH] test/poundbang: Fix relative path of AWKPROG

From: Aharon Robbins
Subject: Re: [bug-gawk] [PATCH] test/poundbang: Fix relative path of AWKPROG
Date: Thu, 19 Jun 2014 20:21:09 +0300
User-agent: Heirloom mailx 12.5 6/20/10

Hi.  Sorry for the delay in getting back to you.

> Date: Wed, 28 May 2014 14:51:49 -0700
> From: Michael Forney <address@hidden>
> To: Aharon Robbins <address@hidden>
> Cc: address@hidden
> Subject: Re: [bug-gawk] [PATCH] test/poundbang: Fix relative path of AWKPROG
> On Wed, May 28, 2014 at 08:52:27AM +0300, Aharon Robbins wrote:
> > Hi.  Can you describe the use case that your patch is fixing, please?
> Sure. If you look at the rule definition for poundbang in
> test/Makefile.am:1187, you'll see that it first tries to use
> `pwd`/$(AWKPROG) as the interpreter for the script.
> On Linux systems, there is a limit of 128 bytes for this path. The
> comments for the poundbang rule mention this, and the rule provides
> a fallback by using a relative path of ../$(AWKPROG). However, if you
> look at the definition of AWKPROG on line 1055, it already contains the
> '../' component. The result is that when the current directory is longer
> than 128 bytes, gawk is looked for in ../../gawk, which lies outside
> the source tree.
> This patch just removes the extra '../', causing it the test to work
> correctly in this fallback case.

I verified the problem and also your fix. I will be pushing this up
to the repo shortly.

Much thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]