[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] [PATCH] Arrange caller of dfa and regex.

From: arnold
Subject: Re: [bug-gawk] [PATCH] Arrange caller of dfa and regex.
Date: Thu, 18 Aug 2016 07:51:48 -0600
User-agent: Heirloom mailx 12.4 7/29/08

Norihiro Tanaka <address@hidden> wrote:

> On Wed, 17 Aug 2016 22:13:16 +0900
> Norihiro Tanaka <address@hidden> wrote:
> > Hi,
> > 
> > Thanks for reviewing and adjusting.  I checked your change has any new
> > problems.
> Ah, dfa can not support RE_NO_BOL.  If it is on, dfa should be avoided.
> dfa always assumes that there is a newline before a start of an input.
> Although "^" has no problem in superset of dfa on before codes, For "<",
> ">", "b" and "B" dfa may reject matches incorrectly.  Attached patch
> fixes it.  It also avoids dfa for RE_NO_BOL.
> Thanks,
> Norihiro

Thanks for the adjusted patch.

Why did you remove the saving and restoring of the final byte and
placing \n there? Is that no longer needed?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]