[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] 4.1.3->4.1.4 = Linux-libre's deblob-check grows huge and

From: Andrew J. Schorr
Subject: Re: [bug-gawk] 4.1.3->4.1.4 = Linux-libre's deblob-check grows huge and takes forever
Date: Fri, 14 Jul 2017 09:01:44 -0400
User-agent: Mutt/1.5.21 (2010-09-15)


On Thu, Jul 13, 2017 at 11:31:03PM -0600, address@hidden wrote:
> What happens if you run the test on stock code using LC_ALL=C ?
> The original comments imply that dfa was made to work correctly
> in multibyte locales. Apparently that assumption isn't correct.
> If LC_ALL=C improves performance that's an interesting piece of
> evidence.

As Alexandre expects, it makes no difference. The deblob-check script already
does this:

bash-4.2$ egrep 'LC_ALL|LANG' deblob-check 
LC_ALL=C; export LC_ALL

So it's not an actual multibyte performance issue.

> If we can isolate a particular regex that is causing the hit, the
> helpers/dfatest.c program would be useful here to figure out why
> and eventually to report it back to the grep / gnulib guys.
> In the meantime, a full revert of that change would need to bring
> back some of the original comments as well.
> Andy --- much thanks for your investigative work. It saved me
> a big chunk of time. :-)

You're welcome. I learned how to use automated git bisect. :-) The question now
is how to fix this properly. I have no idea on that front.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]