[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] $0 reassignment corruption in 4.2

From: arnold
Subject: Re: [bug-gawk] $0 reassignment corruption in 4.2
Date: Tue, 14 Nov 2017 11:51:36 -0700
User-agent: Heirloom mailx 12.4 7/29/08

Hi Andy.

> > The change is probably right. But it should be commented as to what's
> > going on and why the order is important.
> Good point. How's this comment?
>                         /* N.B. We must call assign() before unref, since
>                          * we may need to copy $n values before freeing the
>                          * $0 buffer.
>                          */

Other than I like

                         * Comment start here ...

sorts of comments, it's fine.

Please push the combined patch and test cases to gawk-4.2-stable.

I will try to find time to look at the other two mentioned cases.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]