[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] useless array length abstraction

From: arnold
Subject: Re: [bug-gawk] useless array length abstraction
Date: Sun, 06 Jan 2019 05:30:16 -0700
User-agent: Heirloom mailx 12.5 7/5/10


"Andrew J. Schorr" <address@hidden> wrote:

> I propose the attached patch that removes the alength function and cleans
> up this issue.

This is OK, but is not quite complete. There are, I think, two uses
in symbol.c and one in gawkapi.c where direct access to xxx->table_size
should be replaced by assoc_empty.  Please fix those as well and then
push to master.

> But taking another step back, I'm not sure why these array methods are
> implemented as an array of function pointers instead of as a struct
> with a field for each method.

This would be a step forward.  If you can work up a patch for that for
review, I'd appreciate it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]