[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] [PATCH 0/3] Support for Python format strings in brace
From: |
Stefano Lattarini |
Subject: |
Re: [bug-gettext] [PATCH 0/3] Support for Python format strings in braced syntax |
Date: |
Fri, 14 Dec 2012 11:51:36 +0100 |
On 12/14/2012 11:44 AM, Daiki Ueno wrote:
> Hi Stefano,
>
> Stefano Lattarini <address@hidden> writes:
>
>> I think all the useful explanation you have given in this mail
>> should go in the commit message of the first patch. That way,
>> future developers will be able to understand the big picture of
>> the commit at a glance, reading the commit message, rather than
>> trying to deduce it by reading the details of the change.
>>
>> And probably, you might also want to insert a version of such
>> explanation (maybe abridged, or expanded) also in strategically
>> placed comments in the new code.
>
> Sure. Thanks for the advice.
> I'm slowly learning how other GNU people do :)
>
Actually, I fear not all GNU people agree with me on this need for
commit message explanations; but I'm convinced it's a very good
policy nonetheless, and I try to push it whenever I can.
> Regarding this patch, I'm still not so confident that this is the best
> way, so I'll post v2 later, with proper commit message and comments.
>
> Regards,
Thanks,
Stefano