bug-gettext
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] [Patch 1/2] Libasprintf bug fixes


From: Daiki Ueno
Subject: Re: [bug-gettext] [Patch 1/2] Libasprintf bug fixes
Date: Mon, 04 Mar 2013 22:03:56 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)

Miguel Ángel <address@hidden> writes:

>>     autosprintf& operator = (autosprintf& src)
>
> First of all, const correctness.
> This would be fine with a move reference (C+11) autosprintf&& src, but a
> copy constructor must not modify the copied object.

Thanks for the explanation.  Then, how about:

autosprintf& operator = (autosprintf src)

or just providing autosprintf::swap instead of the assignment operator?

Sorry for grumbling, but I like simplicity.  At least, "autosprintf::"
prefix can be removed from your patch.

Regards,
-- 
Daiki Ueno



reply via email to

[Prev in Thread] Current Thread [Next in Thread]