[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-gettext] [Patch 1/2] Libasprintf bug fixes
From: |
Daiki Ueno |
Subject: |
Re: [bug-gettext] [Patch 1/2] Libasprintf bug fixes |
Date: |
Mon, 04 Mar 2013 22:03:56 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) |
Miguel Ángel <address@hidden> writes:
>> autosprintf& operator = (autosprintf& src)
>
> First of all, const correctness.
> This would be fine with a move reference (C+11) autosprintf&& src, but a
> copy constructor must not modify the copied object.
Thanks for the explanation. Then, how about:
autosprintf& operator = (autosprintf src)
or just providing autosprintf::swap instead of the assignment operator?
Sorry for grumbling, but I like simplicity. At least, "autosprintf::"
prefix can be removed from your patch.
Regards,
--
Daiki Ueno
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, (continued)
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Daiki Ueno, 2013/03/04
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Miguel Ángel Arruga Vivas, 2013/03/05
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Daiki Ueno, 2013/03/05
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Miguel Ángel Arruga Vivas, 2013/03/06
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Didier Spaier, 2013/03/06
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Miguel Ángel Arruga Vivas, 2013/03/06
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Daiki Ueno, 2013/03/06
- Re: [bug-gettext] [Patch 2/2] Libasprintf bug fixes, Miguel Ángel Arruga Vivas, 2013/03/07
Re: [bug-gettext] [Patch 1/2] Libasprintf bug fixes, Daiki Ueno, 2013/03/04