[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-gettext] [PATCH 1/6] Copy string from shared buffer
From: |
Alexander Potashev |
Subject: |
[bug-gettext] [PATCH 1/6] Copy string from shared buffer |
Date: |
Sat, 24 Aug 2013 20:55:18 +0400 |
The buffer "buf" will be reused for other strings. If we pass the
pointer to it to other code, it might later access free'd memory using
that pointer.
---
gettext-tools/src/po-lex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gettext-tools/src/po-lex.c b/gettext-tools/src/po-lex.c
index 3bf5449..9b9704a 100644
--- a/gettext-tools/src/po-lex.c
+++ b/gettext-tools/src/po-lex.c
@@ -945,7 +945,7 @@ po_gram_lex ()
}
buf[bufpos] = '\0';
- po_gram_lval.string.string = buf;
+ po_gram_lval.string.string = xstrdup (buf);
po_gram_lval.string.pos = gram_pos;
po_gram_lval.string.obsolete = po_lex_obsolete;
po_lex_obsolete = false;
--
1.8.1.5
- [bug-gettext] [PATCH 0/6] Fix various memory leaks in libgettextpo, Alexander Potashev, 2013/08/24
- [bug-gettext] [PATCH 1/6] Copy string from shared buffer,
Alexander Potashev <=
- [bug-gettext] [PATCH 2/6] Fix memory leak: do not duplicate msgid_plural in message_alloc, Alexander Potashev, 2013/08/24
- [bug-gettext] [PATCH 3/6] Fix memory leak: free msgctxt in message_free, Alexander Potashev, 2013/08/24
- [bug-gettext] [PATCH 4/6] Fix memory leak: po_callback_comment_dispatcher does not take ownership of the string passed into it, Alexander Potashev, 2013/08/24
- [bug-gettext] [PATCH 5/6] Fix memory leak: string_list_append duplicates the string, Alexander Potashev, 2013/08/24
- [bug-gettext] [PATCH 6/6] Fix memory leak: free gram_pos.file_name in lex_end(), Alexander Potashev, 2013/08/24
- Re: [bug-gettext] [PATCH 0/6] Fix various memory leaks in libgettextpo, Daiki Ueno, 2013/08/27