bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: question about gtagsop.c


From: Shigio Yamaguchi
Subject: Re: question about gtagsop.c
Date: Wed, 20 Jul 2005 19:51:48 +0900

> When using compact format, gtop->root is always overwritten
> by the 2nd argument of gtags_open.
> 
>   322         if (gtop->format & GTAGS_COMPACT) {
>   323                 assert(root != NULL);
>   324                 strlimcpy(gtop->root, root, sizeof(gtop->root));
> 
> The thing which I want to know is when an empty string("") 
> is specified by the 2nd argument of gtags_open.
> If it never happen, this check will be meaningless.

Though it is the usual, I don't know the original intension without reading
the code too. I'm reflecting not writing the comment in this part neatly.
By the way, if it works well, we need not necessarily fix it?
--
Shigio YAMAGUCHI <address@hidden> - Tama Communications Corporation
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]