bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Keybinding Patch gtags.el


From: Stan Moore
Subject: Keybinding Patch gtags.el
Date: Mon, 2 Sep 2013 22:58:55 -0400

Greetings,
I don't consider this an actual full blown bug, but it is surprising as
browsing the web indicates. Many examples like:

(gtags-mode t)
(gtags-suggested-key-mapping t)

indicate that many people expect the above to actually enable the key
bindings. Currently gtags.el only loads keybindings at load time so the
gtags-suggested-key-mapping is too late and therefore is ignored. I created
a patch to allow keybinding when the mode is activated vs only during load.
Along the way I removed some redundant code for a somewhat cleaner yet still
not totally intuitive logic.

After the patch either

  (setq gtags-suggested-key-mapping t)
  (gtags-mode t)

Or 

 (gtags-mode t)
 (setq gtags-suggested-key-mapping t)
 (gtags-bind-custom-keys)

Will enable the keybindings. The original, and quite common example code,
will still not enable keybinding.  In addition to this patch I would suggest
either changing the docs or changing the default value of
gtags-suggested-key-mapping.

I'm currently away from my regular environment so I may not see the list
very soon but I will check in at some point in the future.

Stan Moore

Attachment: gtags.el.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]