gnatsd SEGV's with no gnats-adm/states file

[Eric Siegerman]

[Sorry this isn't structured as a PR submission.  I've never been
able to figure out send-pr's baroque email format -- or rather,
I've figured it out a couple of times but always forget.  On a
day-to-day basis, I only ever deal with gnatsweb.]

The gnats-adm/states file went missing from one of our GNATS
databases.  When someone subsequently tried to add a PR,
gnatsweb said something like "unparseable reply from GNATS".

The problem is in gnatsd, which, under these conditions, SEGV's
on a null-pointer dereference (and leaves the gnats.lock file
behind).  The "unparseable" reply that gnatsweb complains about
is actually no reply at all; I guess the process dies before
writing one to the socket.

The null pointer is variable default_val in createNewPRFile(),
specifically, in the "Ensure the PR has a valid STATE" code.

Attached are:
  - a gdb session, with stack backtrace
  - a copy of gnats-adm/dbconfig; there are local changes from
    the distributed version, but the `field "State"' paragraph is
    unmodified

--

|  | /\
|-_|/  >   Eric Siegerman, Toronto, Ont.        erics@telepres.com
|  |  /
It must be said that they would have sounded better if the singer
wouldn't throw his fellow band members to the ground and toss the
drum kit around during songs.
        - Patrick Lenneau

gdb-session
Description: Text document

dbconfig
Description: Text document