[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

simple.el patch fixes ffap.el in emacs 20.7

From: Jeff Morgenthaler
Subject: simple.el patch fixes ffap.el in emacs 20.7
Date: Thu, 28 Dec 2000 20:09:24 -0600

Using ffap (find-file-at-point), if you try to find a file not in the
current directory AND finish the completion using the mouse or the
point in the *Completions* buffer, you get a file in the current
directory, not the directory you just completed to.  The problem seems
to be an inconsistent definition of the variable completion-base-size
in simple.el (nil vs 0) for the special case when you are finding a
file.  The comments before choose-completion-string imply that
completion-base-size should be set to nil in order for the entire
contents of the minibuffer to be returned from the *Completions*
buffer.  Completion-setup-function, however, sets completion-base-size
to 0.  The following patch fixes this, and does not seem to induced
problems in other packages that use completion.


cd /usr/local/share/emacs/20.7/lisp/
diff -c /usr/local/share/emacs/20.7/lisp/simple.el\~ 
*** /usr/local/share/emacs/20.7/lisp/simple.el~ Tue May  2 07:36:41 2000
--- /usr/local/share/emacs/20.7/lisp/simple.el  Thu Dec 28 19:02:38 2000
*** 3958,3964 ****
          (if (string-match "\\` \\*Minibuf-[0-9]+\\*\\'"
                            (buffer-name mainbuf))
!             (setq completion-base-size 0))))
        (goto-char (point-min))
        (if window-system
          (insert (substitute-command-keys
--- 3958,3964 ----
          (if (string-match "\\` \\*Minibuf-[0-9]+\\*\\'"
                            (buffer-name mainbuf))
!             (setq completion-base-size nil))))
        (goto-char (point-min))
        (if window-system
          (insert (substitute-command-keys

Diff finished at Thu Dec 28 19:07:38

reply via email to

[Prev in Thread] Current Thread [Next in Thread]