[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

browse-url-new-window-p in browse-url.el needs full rethinking

From: Matt Swift
Subject: browse-url-new-window-p in browse-url.el needs full rethinking
Date: Mon, 9 Apr 2001 12:44:16 -0400

This bug report will be sent to the Free Software Foundation,
 not to your local site managers!!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

In GNU Emacs 20.7.2 (i386-debian-linux-gnu, X toolkit)
 of Tue Jul 25 2000 on raven
configured using `configure  i386-debian-linux-gnu --prefix=/usr 
--sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib 
--infodir=/usr/share/info --with-pop=yes --with-x=yes --with-x-toolkit=yes'

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I see now why a year ago I defined my own versions of functions in
browse-url.el:  I could never get browse-url-new-window-p to work as

The current situation in 20.7 is that functions calling `browse-url-netscape' 
have to
explicitly pass `browse-url-new-window-p' to it in order for that variable's
value to be taken into account.  This is a foolish design.  When a function
(e.g., in Gnus) calls simply `browse-url', it should be able to do so without
having to pass it `browse-url-new-window-p'.   

There are several ways to resdesign of course.  Here's a few comments.

I don't see why `browse-url' takes "&rest args".  Either it should take no
arguments or the potential arguments should be standardized so each function
that might in turn get called by `browse-url' can be written to accommodate
a specific list of optional arguments.

`browse-url-netscape' (and the parallel browse-url-someotherbrowser functions)
should use a new window based simply on `browse-url-new-window-p'.  Functions
that want to override this setting can do so by binding it with `let'.

I'll send you a rewritten and tested .el file when I get around to doing it.

Recent input:
M-s return t C-s d e b u g C-a return SPC down down 
down down down down down down down down down down down 
down down down down return u M-< M-s c o n d i t i 
o n - c a s e return M-< M-s u n w i n d - p r o t 
e c t return M-s return l M-s return M-s return M-s 
return M-s return M-s return C-a return next prior 
M-x r e p o r t - e m a c s - b u g return

Recent messages:
decompressing elisp-41.gz...done
Searching subfile elisp-42...
decompressing elisp-42.gz...
decompressing elisp-42.gz...done

decompressing elisp-8.gz...
decompressing elisp-8.gz...done
TRACE current buffer *info* [2 times]
Loading emacsbug...
Loading emacsbug...done

reply via email to

[Prev in Thread] Current Thread [Next in Thread]