bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: very wierd commit from emacs (or ntemacs) problem


From: Eli Zaretskii
Subject: Re: very wierd commit from emacs (or ntemacs) problem
Date: Fri, 04 May 2001 15:52:53 +0300

> From: Steve Kemp <address@hidden>
> Newsgroups: gnu.emacs.bug
> 
> On Fri, 4 May 2001, Eli Zaretskii wrote:
> > All the uses of a literal /bin/sh are bugs, so please report them to
> > gnu.emacs.bug.  Emacs should use the value of shell-file-name.
> 
>   The following files appear to use /bin/sh inappropriately:
> 
>       md5.el
>       terminal.el
>       feedmail.el
>       mh-comp.el

Thanks!

md5.el doesn't exist in Emacs 21.  terminal.el indeed invokes /bin/sh,
but to fix that, the entire fragment which uses the shell should be
rewritten, since it invokes `env' etc.  I will look into that (your
diffs will not work if the user sets the shell to a Windows shell).
feedmail.el and mh-comp.el are okay, since they use /bin/sh in
conjunction with mailers which only work on Unix.

>   In addition to this pop3.el uses "shell-file-name", rather
>  than explicit-shell-file-name - I'm not sure if this is a bug
>  or not..

It is actually a bug to use explicit-shell-file-name unconditionally:
this variable only exists in the Windows version of Emacs.  So at the
very least, Lisp programs should see if it is boundp and non-nil
before using it, and fall back on shell-file-name if not.

>    `tex-mode.el' also seems a little broken.

Yes, but your change uses explicit-shell-file-name unconditionally...

Thanks, I'll take care of these gotchas.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]