[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NEWS entry for perform-replace is incorrect

From: Hannu Koivisto
Subject: NEWS entry for perform-replace is incorrect
Date: 24 Oct 2001 13:55:38 +0300
User-agent: Gnus/5.090003 (Oort Gnus v0.03) Emacs/20.7


In Emacs 21.1, NEWS entry concerning perform-replace is under "*
Lisp changes in Emacs 21.1" section and says:

** The functions `query-replace', `query-replace-regexp',
`query-replace-regexp-eval' `map-query-replace-regexp',
`replace-string', `replace-regexp', and `perform-replace' take two
additional optional arguments START and END that specify the region
to operate on.

This doesn't seem to be the case if you look at the help for
perform-replace with C-h f perform-replace RET:

perform-replace is a compiled Lisp function in `replace'.

That is, START and END are not optional.  This also means that this
is an incompatible Lisp change and should probably be listed under
"* Incompatible Lisp changes" section.

That is, if you want to retain this change.  It seems to be
inconsistent with changes to query-replace and other functions
listed in that entry.  It also breaks at least cal-desk-calendar.
If I were you, I would alter perform-replace so that those
arguments are indeed last two optional arguments.  If you are going
to retain this change, which I disapprove, then I suggest that you
include PROBLEMS entry for cal-desk-calendar with a patch that
fixes the problem with it.  I can provide such a patch if the
author of cal-desk-calendar can't be reached (I won't try until I
hear whether you intend to retain this mistake or not).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]