Re: toolbar display bug

[Gerd Moellmann]

raphael.berbain@bigfoot.com (Raphaël Berbain) writes:

> | (setq tool-bar-button-margin 10)
> `----
> 
> start emacs with:
> emacs -geometry 40x20 -q --no-site-file -l tb.el
> move the mouse over the last toolbar button (the question mark).
> There's a vertical line that appears on the left of the '?' toolbar
> button.  Also, it looks like there's an extra black pixel at the lower
> right corner of each button when the mouse pointer is over the button.
> <screenshot: emacs-5-tb.png>

Thanks, Raphaël.  The fix should hopefully be

*** xterm.c.~1.675.~    Mon Oct 29 14:58:23 2001
--- xterm.c     Tue Oct 30 15:58:08 2001
***************
*** 3907,3913 ****
    for (i = 0; i < width; ++i)
      XDrawLine (dpy, window, gc,
               left_x + i * left_p, bottom_y - i,
!              right_x + 2 - i * right_p, bottom_y - i);
    
    /* Right.  */
    if (right_p)
--- 3907,3913 ----
    for (i = 0; i < width; ++i)
      XDrawLine (dpy, window, gc,
               left_x + i * left_p, bottom_y - i,
!              right_x + 1 - i * right_p, bottom_y - i);
    
    /* Right.  */
    if (right_p)
***************
*** 4004,4010 ****
             || (s->hl == DRAW_MOUSE_FACE
                 && (s->next == NULL
                     || s->next->hl != s->hl)));
!   
    x_get_glyph_string_clip_rect (s, &clip_rect);
  
    if (s->face->box == FACE_SIMPLE_BOX)
--- 4004,4010 ----
             || (s->hl == DRAW_MOUSE_FACE
                 && (s->next == NULL
                     || s->next->hl != s->hl)));
! 
    x_get_glyph_string_clip_rect (s, &clip_rect);
  
    if (s->face->box == FACE_SIMPLE_BOX)
***************
*** 4826,4832 ****
               || s->face->background != default_face->background
               || s->face->stipple != default_face->stipple
               || s->row->mouse_face_p))
!         || s->hl == DRAW_MOUSE_FACE))
        s->extends_to_end_of_line_p = 1;
    
    /* If S extends its face to the end of the line, set its
--- 4826,4834 ----
               || s->face->background != default_face->background
               || s->face->stipple != default_face->stipple
               || s->row->mouse_face_p))
!         || s->hl == DRAW_MOUSE_FACE
!         || ((s->hl == DRAW_IMAGE_RAISED || s->hl == DRAW_IMAGE_SUNKEN)
!             && s->row->fill_line_p)))
        s->extends_to_end_of_line_p = 1;
    
    /* If S extends its face to the end of the line, set its