bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug xml parser emacs 21.1


From: Stefan Monnier
Subject: Re: bug xml parser emacs 21.1
Date: 03 Nov 2001 20:03:04 -0500
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1.50

>>>>> "Stefan" == Stefan Monnier <monnier+gnu.emacs.bug/news/@RUM.cs.yale.edu> 
>>>>> writes:
> Agreed.  The patch below should fix it.
> But I'm not sure what should happen in a case like
>   <one>haha<!--comment-->hihi</one>
> Should "haha" and "hihi" be returned as separate strings or
> should they be concatenated into one ?

Looks like Emacs failed to infer from the above that it should
have attached a patch.  I guess I'll have to do it the hard way.


        Stefan


Index: xml.el
===================================================================
RCS file: /cvs/emacs/lisp/xml.el,v
retrieving revision 1.8
diff -u -u -b -r1.8 xml.el
--- xml.el      2001/10/18 20:22:53     1.8
+++ xml.el      2001/11/04 00:45:21
@@ -207,7 +207,7 @@
    ((looking-at "<!--")
     (search-forward "-->" end)
     (skip-chars-forward " \t\n")
-    (xml-parse-tag end))
+    nil)
    ;;  end tag
    ((looking-at "</")
     '())
@@ -244,9 +244,11 @@
                          node-name
                          ") at pos " (number-to-string (point)))))
                 ((= (char-after) ?<)
-                 (set 'children (append children (list (xml-parse-tag end)))))
+                 (let ((tag (xml-parse-tag end)))
+                   (when tag
+                     (setq children (append children (list tag))))))
                 (t
-                 (set 'pos (point))
+                 (setq pos (point))
                  (search-forward "<" end)
                  (forward-char -1)
                  (let ((string (buffer-substring-no-properties pos (point)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]