bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

vc.el and diff-switches containing "-r"


From: Michael Ernst
Subject: vc.el and diff-switches containing "-r"
Date: Mon, 25 Mar 2002 17:42:53 -0500

vc.el unconditionally uses `diff-switches' (though it also concatenates
`vc-diff-switches').  However, some switches that are sensible in
`diff-switches' are not sensible as arguments to (say) "cvs diff".  This
patch corrects the problem.  (Another solution would be for
`vc-diff-switches' to override `diff-switches', if set, rather than for
both to be used.)

2002-03-25  Michael Ernst  <address@hidden>

        * vc.el (vc-diff-internal, vc-diff-switches-list): Remove "-r"
        from `diff-switches'.

*** /usr/local/share/emacs/21.2/lisp/vc.el      Wed Mar 13 14:51:46 2002
--- -   Mon Mar 25 16:06:25 2002
***************
*** 1815,1821 ****
      (if (and file-rel1 file-rel2)
          (apply 'vc-do-command "*vc-diff*" 1 "diff" nil
!                (append (if (listp diff-switches)
!                            diff-switches
!                          (list diff-switches))
                         (if (listp vc-diff-switches)
                             vc-diff-switches
--- 1815,1822 ----
      (if (and file-rel1 file-rel2)
          (apply 'vc-do-command "*vc-diff*" 1 "diff" nil
!                (append (remove "-r"
!                              (if (listp diff-switches)
!                                  diff-switches
!                                (list diff-switches)))
                         (if (listp vc-diff-switches)
                             vc-diff-switches
***************
*** 1828,1832 ****
    "Return the list of switches to use for executing diff under BACKEND."
    `(append 
!     (if (listp diff-switches) diff-switches (list diff-switches))
      (if (listp vc-diff-switches) vc-diff-switches (list vc-diff-switches))
      (let ((backend-switches 
--- 1829,1834 ----
    "Return the list of switches to use for executing diff under BACKEND."
    `(append 
!     (remove "-r"
!             (if (listp diff-switches) diff-switches (list diff-switches)))
      (if (listp vc-diff-switches) vc-diff-switches (list vc-diff-switches))
      (let ((backend-switches 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]