bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Command `browse-url-galeon' in browse-url.el


From: Bodo Schulze
Subject: Command `browse-url-galeon' in browse-url.el
Date: Sat, 09 Aug 2003 22:06:07 +0200

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the address@hidden mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-03-22 on raven, modified by Debian
configured using `configure  i386-debian-linux-gnu --prefix=/usr 
--sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib 
--infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes 
--with-x-toolkit=athena --without-gif'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Using galeon version 1.2.5

In a buffer being in text-mode, I placed point on

  file:///usr/local/doc/HOWTO/Text-Terminal-HOWTO-9.html

then called

  M-x browse-url-galeon

This works fine. Then I issue:

  M-x browse-url-new-window-flag RET t RET

place point on

  file:///usr/local/doc/HOWTO/Text-Terminal-HOWTO-8.html

and call again

  M-x browse-url-galeon

This last file gets shown in the same window as the first one, but
should be shown in a new window.

In defun browse-url-galeon in browse-url-el, I read this:

         (process (apply 'start-process
                         (concat "galeon " url) nil
                         browse-url-galeon-program
                         (append
                          browse-url-galeon-arguments
                          (if new-window '("-w" "--noraise"))
                          (list "-x" url)))))

I guess the option -x (for 'show in same window') shadows the earlier
option -w (for 'show in new window').  Also --noraise is not mentioned in 
the manual of Galeon version 1.2.5

Here is a patch that I found to correct the problem:


*** browse-url.el.orig  Sat Aug  9 19:58:27 2003
--- browse-url.el       Sat Aug  9 19:58:27 2003
***************
*** 901,908 ****
                         browse-url-galeon-program
                         (append
                          browse-url-galeon-arguments
!                           (if new-window '("-w" "--noraise"))
!                           (list "-x" url)))))
      (set-process-sentinel process
                          `(lambda (process change)
                             (browse-url-galeon-sentinel process ,url)))))
--- 904,912 ----
                         browse-url-galeon-program
                         (append
                          browse-url-galeon-arguments
!                         ;; -w does not pass through with -x
!                         (list (if new-window "-w" "-x")
!                               url)))))
      (set-process-sentinel process
                          `(lambda (process change)
                             (browse-url-galeon-sentinel process ,url)))))

Hope it helps.

Additional remark:

Galeon now can open a file in a new Tab. Emacs does not yet provide a
flag for this useful option.  I already mentioned this in an earlier
bug-report on `browse-url-mozilla' in browse-url.el.  Should there be a
new flag, or would it be better to leave it to the user to specify the
desired behaviour in `browse-url-galeon-arguments' and
`browse-url-mozilla-arguments' altogether?

Best regards,
Bodo Schulze




reply via email to

[Prev in Thread] Current Thread [Next in Thread]