[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: accept-process-output incompatible change in CVS Emacs: patch includ
Kim F. Storm
Re: accept-process-output incompatible change in CVS Emacs: patch included
Sat, 05 May 2007 00:33:39 +0200
Gnus/5.11 (Gnus v5.11) Emacs/22.0.98 (gnu/linux)
Per Cederqvist <firstname.lastname@example.org> writes:
> This change in the upcoming Emacs 22 breaks some code:
>> 2006-03-22 Kim F. Storm <email@example.com>
>> * process.c (Faccept_process_output): Fix to comply with lisp
>> reference. Change arg "timeout" to "seconds" and allow both
>> integer and float value. Change arg "timeout-msec" to "millisec"
>> and interpret" as milliseconds rather than microseconds. Fix doc
>> string accordingly.
> I enclose a patch that makes accept-process-output
> backwards-compatible with Emacs 21.
> One application I'm running now runs very slowly, since its carefully
> tuned timeoutes are multiplied by 1000.
Well, other code believing the lisp ref, and was broken by the old
So just reverting the change is no good at this time.
What application is that?
> If, for some reason, my patch is unacceptable, please
> mention this as an incompatible change in the NEWS file.
This is a good point.
Kim F. Storm http://www.cua.dk