[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#308: vc-delete-file
From: |
Dan Nicolaescu |
Subject: |
bug#308: vc-delete-file |
Date: |
Fri, 23 May 2008 14:38:24 -0700 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> No need to argue that it's a bug, I agree.
> [ For what it's worth, I'd recommend you vc-delete-file before doing
> your tests, tho. After all, you can always undo it before committing
> if it turns out it was a bad idea. ]
>
> > Debugger entered--Lisp error: (error "File myfilename no longer exists!")
> > signal(error ("File myfilename no longer exists!"))
> > error("File %s no longer exists!" "myfilename")
> > revert-buffer(t t t)
> > vc-revert-buffer-internal(t t)
> > vc-resynch-window("myfilename" #<buffer convert_config.mli> t)
> > vc-resynch-buffer("myfilename" #<buffer convert_config.mli> t)
> > vc-delete-file("myfilename")
> > call-interactively(vc-delete-file t nil)
> > execute-extended-command(nil)
> > call-interactively(execute-extended-command nil nil)
>
> > i.e., you just deleted it yourself - and now you are complaining that
> > the file does not exist!
> > I would rather expect kill-buffer instead of revert-buffer.
>
> I've just changed the code to kill the buffer, indeed.
That's not quite right, the *vc-dir* buffers where this file might have
been displayed need to be updated. I checked in an alternative fix
that I've had in my tree and seems to DTRT.