bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#722: More Visual Studio 6.0 compiler errors on Windows XP


From: Eli Zaretskii
Subject: bug#722: More Visual Studio 6.0 compiler errors on Windows XP
Date: Fri, 15 Aug 2008 20:02:20 +0300

> Date: Fri, 15 Aug 2008 12:39:27 -0400
> From: "Fran Litterio" <flitterio@gmail.com>
> Cc: 722@emacsbugs.donarmstrong.com, schwab@suse.de, 
>       bug-submit-list@donarmstrong.com, bug-gnu-emacs@gnu.org, 
>       don@donarmstrong.com
> 
> > Emacs has always compiled using VC++ 6.0 in the past, so some change
> > > must have introduced this problem.
> >
> > The problems in w32.c are due to a recent change I did to impement two
> > new primitives, but the change in dired.c that made st_size be
> > unsigned 64-bit type is fairly old.  When did you last build the CVS
> > code?
> >
> 
> Some timestamp sleuthing leads me to believe it was Jan 19th, 2008.

In that case, it is quite probable that you didn't see those changes
then.

> > Also, a 64-bit integer (signed or unsigned) cannot safely be cast to
> > > double without loss of data.
> >
> > Yes, when file sizes will start hitting 64-bits, we will start losing
> > precision here.  But I hope till then all compilers will have long
> > double data type, and then this code could be fixed.
> 
> 
> Good point!

Maybe I should simply make st_size be a signed 64-bit type.  Does
anyone see any problems with that?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]