--- Begin Message ---
Subject: |
Re: regexp problem in ldap.el |
Date: |
Mon, 11 Aug 2008 19:17:37 +0900 |
User-agent: |
cmail/2.62 (via feedmail 11-beta-1 I) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/21.4 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) |
Hi,
According to the rfc4512, \w is not good to match aginst attribuite type
and options. Wtith the attached patch, options containing hyphens are
sucessfully parsed.
P.S.
I submitted a bug report about regexp in ldap-search-internal last
December, but now I understand that it was a mistake.
--
/*** Hewlett-Packard Japan, Ltd. ***/
/*** Consulting & Integration ***/
/*** PC-CW-SOL#1 Professional Center ***/
/*** Nakagawa, Makoto(中川 誠) 050 3158 4747 (Dial-In) ***/
/*** PGP: 0B33 EAC3 F2F6 3D10 D9E9 AE7F 8EDA 44F9 1D29 D44A ***/
bink8djkUQmcv.bin
Description: Binary data
pgpVJN49Orydo.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Subject: |
Re: regexp problem in ldap.el |
Date: |
Sun, 24 Aug 2008 00:23:33 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.2.90 (gnu/linux) |
gha03025@nifty.ne.jp (中川 誠) writes:
> What I mean by garbage is backslash and LF at the end of lines.
> Shouldn't it be like the following?
>
> --- from here ---
> --- ldap.1.26.2.3.el 2008-08-24 06:40:45.000000000 +0900
> +++ ldap.el 2008-08-24 06:46:27.000000000 +0900
> @@ -584,9 +584,7 @@
> (end-of-line)
> (point))))
> (forward-line 1)
> - (while (looking-at "^\\([A-Za-z][-A-Za-z0-9]*\
> -\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t ]+\
> -\\(<[\t ]*file://\\)\\(.*\\)$")
> + (while (looking-at
> "^\\([A-Za-z][-A-Za-z0-9]*\\|[0-9]+\\(?:\\.[0-9]+\\)*\\)\\(;[-A-Za-z0-9]+\\)*[=:\t
> ]+\\(<[\t ]*file://\\)\\(.*\\)$")
> (setq name (match-string 1)
> value (match-string 4))
> ;; Need to handle file:///D:/... as generated by OpenLDAP
That's just to break up the long string into lines so it is easier to
read. It shouldn't affect the functioning of the lisp code.
--- End Message ---