bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#1239: marked as done (PATCH: Fix corner case of texinfo-insert-quot


From: Emacs bug Tracking System
Subject: bug#1239: marked as done (PATCH: Fix corner case of texinfo-insert-quote)
Date: Mon, 1 Dec 2008 19:45:04 -0800

Your message dated Mon, 01 Dec 2008 22:37:34 -0500
with message-id <address@hidden>
and subject line Re: bug#1239: PATCH: Fix corner case of texinfo-insert-quote
has caused the Emacs bug report #1239,
regarding PATCH: Fix corner case of texinfo-insert-quote
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
1239: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1239
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: PATCH: Fix corner case of texinfo-insert-quote Date: Fri, 24 Oct 2008 13:40:46 -0400 User-agent: Thunderbird 2.0.0.16 (X11/20080723) Patch is attached and in-line. It would be nice to have this, in case one tries to do quotation mark manipulation with with-temp-buffer.

Thanks for Emacs,
/a

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.14668
diff -u -r1.14668 ChangeLog
--- ChangeLog   24 Oct 2008 09:39:28 -0000      1.14668
+++ ChangeLog   24 Oct 2008 17:29:37 -0000
@@ -1,3 +1,8 @@
+2008-10-24  Aaron S. Hawley  <address@hidden>
+
+       * textmodes/texinfo.el (texinfo-insert-quote): Handle corner
+        case where point is at the beginning of the buffer.
+
 2008-10-24  Juanma Barranquero  <address@hidden>

        * subr.el (locate-user-emacs-file): New function.
Index: textmodes/texinfo.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v
retrieving revision 1.122
diff -u -r1.122 texinfo.el
--- textmodes/texinfo.el        6 May 2008 04:33:13 -0000       1.122
+++ textmodes/texinfo.el        24 Oct 2008 17:29:37 -0000
@@ -682,7 +682,9 @@
     (if (or arg
            (= (preceding-char) ?\\)
            (save-excursion
-             (backward-char (length texinfo-open-quote))
+             (if (> (point) (length texinfo-open-quote))
+                 (backward-char (length texinfo-open-quote))
+               (goto-char (point-min)))
              (when (or (looking-at texinfo-open-quote)
                        (looking-at texinfo-close-quote))
                (delete-char (length texinfo-open-quote))
@@ -694,7 +696,8 @@
                    (setq in-env t)))))
        (self-insert-command (prefix-numeric-value arg))
       (insert
-       (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))
+       (if (or (bobp) ;; (eq (preceding-char) 0)
+              (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)))
           texinfo-open-quote
         texinfo-close-quote)))))

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.14668
diff -u -r1.14668 ChangeLog
--- ChangeLog   24 Oct 2008 09:39:28 -0000      1.14668
+++ ChangeLog   24 Oct 2008 17:29:37 -0000
@@ -1,3 +1,8 @@
+2008-10-24  Aaron S. Hawley  <address@hidden>
+
+       * textmodes/texinfo.el (texinfo-insert-quote): Handle corner
+        case where point is at the beginning of the buffer.
+
 2008-10-24  Juanma Barranquero  <address@hidden>
 
        * subr.el (locate-user-emacs-file): New function.
Index: textmodes/texinfo.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v
retrieving revision 1.122
diff -u -r1.122 texinfo.el
--- textmodes/texinfo.el        6 May 2008 04:33:13 -0000       1.122
+++ textmodes/texinfo.el        24 Oct 2008 17:29:37 -0000
@@ -682,7 +682,9 @@
     (if (or arg
            (= (preceding-char) ?\\)
            (save-excursion
-             (backward-char (length texinfo-open-quote))
+             (if (> (point) (length texinfo-open-quote))
+                 (backward-char (length texinfo-open-quote))
+               (goto-char (point-min)))
              (when (or (looking-at texinfo-open-quote)
                        (looking-at texinfo-close-quote))
                (delete-char (length texinfo-open-quote))
@@ -694,7 +696,8 @@
                    (setq in-env t)))))
        (self-insert-command (prefix-numeric-value arg))
       (insert
-       (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))
+       (if (or (bobp) ;; (eq (preceding-char) 0)
+              (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)))
           texinfo-open-quote
         texinfo-close-quote)))))
 

--- End Message ---
--- Begin Message --- Subject: Re: bug#1239: PATCH: Fix corner case of texinfo-insert-quote Date: Mon, 01 Dec 2008 22:37:34 -0500 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
OK; installed.

2008-12-02  Aaron S. Hawley  <address@hidden>

  * textmodes/texinfo.el (texinfo-insert-quote): Handle
  corner case where point is at the beginning of the buffer.  (Bug#1239)


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]