bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#870: Repeatable instance of bug#870


From: Jason Rumney
Subject: bug#870: Repeatable instance of bug#870
Date: Mon, 05 Jan 2009 19:22:16 +0800
User-agent: Thunderbird 2.0.0.19 (Windows/20081209)

Juanma Barranquero wrote:
On Mon, Jan 5, 2009 at 11:59, Jason Rumney <jasonr@gnu.org> wrote:

It appears that there is a bug in all the decode_coding_* functions when a
CR lies on a CHARBUF_SIZE (0x4000) boundary with a matching LF on the other
side of the boundary.

They all do something like:

    if (eol_crlf && c1 == '\r')
      ONE_MORE_BYTE (byte_after_cr);

but ONE_MORE_BYTE will abort the decode if it reaches the end of the buffer,
leaving the CR in limbo between having been read and being added to the
buffer. Then on decoding the subsequent block, the initial LF does not trip
the normal CRLF decoding, so it is put into the buffer.

Wouldn't that mean that, on writing the buffer, the file would end
with extra CRs, instead of missing LFs?
The CRs are effectively stripped on reading, since they end up in limbo between being read and being added to the decoding buffer. I haven't tried writing the file, but I think (from memory and from the way the code looks to me) the problem is a missing CR, not a missing LF.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]