bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#2228: 23.0.90; rmail-cease-edit ignores changes to the message heade


From: Eli Zaretskii
Subject: bug#2228: 23.0.90; rmail-cease-edit ignores changes to the message headers
Date: Tue, 10 Feb 2009 10:56:51 +0200

> From: Glenn Morris <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Mon, 09 Feb 2009 22:38:30 -0500
> 
> rmailedit as a whole seems overly complex to me. If I were doing it,
> I'd copy the expanded message text to a new buffer for editing, rather
> than re-using the rmail buffer.

??? The buffer where the current Rmail shows the message _is_ a
separate buffer.  It holds only the single message that is shown, not
the whole message collection.  Why do you need yet another buffer?

> Aborting an edit would just kill the buffer.

You can replace that with erasing it and then re-displaying the
current message with rmail-show-message.

> Saving an edit would compare the buffer text with the region
> between msgbeg and msgend in rmail-view-buffer, and swap it in if it
> differed, then call rmail-show-message.

You could do that with the current arrangement as well, can't you?

But please be very conservative about throwing away the existing code
in rmailedit: some of it could actually implement valuable features.
We have been bit by that in the very recent past: a too naive approach
to reimplementing features anew which lost some of them in the
process, because there's no requirements spec for what Rmail does.
The current trail of Rmail-related bugs is the evidence of how
dangerous that can be.

Thanks.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]