[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#1904: marked as done (23.0.60; [PATCH] sql-sqlite doesn't work)

From: Emacs bug Tracking System
Subject: bug#1904: marked as done (23.0.60; [PATCH] sql-sqlite doesn't work)
Date: Sat, 14 Feb 2009 03:45:05 +0000

Your message dated Fri, 13 Feb 2009 22:38:20 -0500
with message-id <address@hidden>
and subject line Re: 23.0.60; [PATCH] sql-sqlite doesn't work
has caused the Emacs bug report #1904,
regarding 23.0.60; [PATCH] sql-sqlite doesn't work
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden

1904: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1904
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 23.0.60; [PATCH] sql-sqlite doesn't work Date: Wed, 14 Jan 2009 10:57:49 -0800 The (sql-sqlite) function prompts for username, password, and server even though these don’t apply to SQLite. Further, it adds options for them (--host, --user, --password) to the arguments of sql-sqlite- program. The SQLite CLI doesn’t understand or support these, and returns this error if they’re provided:

sqlite3: unknown option: -user=ieure

(The sqlite 2.8.x binary behaves in the same way.)

For these reasons, I’ve taken the following measures:

1. Removed 'user, 'password and 'server from :sqli-login for sqlite in sql-product-alist; this prevents them from being read from the user when (sql-sqlite) is invoked. 2. Removed the addition of the --host, --user, and --password arguments to 'params in (sql-connect-sqlite).

Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows.

--- sql.el.~1.61.~      2009-01-14 10:44:58.000000000 -0800
+++ sql.el      2009-01-14 10:50:09.000000000 -0800
@@ -356,7 +356,7 @@
      :sqli-prompt-length 0)
      :font-lock sql-mode-sqlite-font-lock-keywords
-     :sqli-login (user password server database)
+     :sqli-login (database)
      :sqli-connect sql-connect-sqlite
      :sqli-prompt-regexp "^sqlite> "
      :sqli-prompt-length 8)
@@ -2611,12 +2611,6 @@
   (let ((params))
     (if (not (string= "" sql-database))
        (setq params (append (list sql-database) params)))
-    (if (not (string= "" sql-server))
-       (setq params (append (list (concat "--host=" sql-server)) params)))
-    (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password)) params)))
-    (if (not (string= "" sql-user))
-       (setq params (append (list (concat "--user=" sql-user)) params)))
     (if (not (null sql-sqlite-options))
        (setq params (append sql-sqlite-options params)))
     (set-buffer (apply 'make-comint "SQL" sql-sqlite-program

In GNU Emacs (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-01-14 on neutron.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
  diff-auto-refine-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-spelling-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  erc-scrolltobottom-mode: t
  which-function-mode: t
  twit-mode: t
  yas/minor-mode: t
  ime-bindings: t
  shell-dirtrack-mode: t
  show-paren-mode: t
  recentf-mode: t
  iswitchb-mode: t
  auto-insert-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v
C-v C-v C-x k RET C-x b s h e l <return> M-> c d SPC
~ / P r <tab> e m <tab> <return> c v s SPC u p SPC
- A <return> C-x 1 C-p C-p C-p C-p C-p C-p C-p C-p
C-SPC M-b M-b M-b M-b M-b M-b M-w M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> s v n SPC <M-backspace>
x c s a SPC a r <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> c v
s SPC u p <return> C-p C-x b s q l C-g C-x b s q l
. e l <return> C-x k RET C-x b s q l . e l <return>
C-x k RET M-> C-p C-p M-- M-z SPC M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> C-p C-p C-p C-e C-c
C-x C-f RET C-x v = C-s s q l - c o n n e c t - s q
l i t e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-h
v p r o g <tab> m <tab> C-g C-n C-p C-p C-p C-a C-n
M-m C-SPC C-n C-n C-n C-n C-n C-n C-p C-e C-w C-d <tab>
C-h v w r <tab> <tab> i <tab> <M-backspace> e <backspace>
e <backspace> v f <tab> <backspace> <backspace> b e
f <tab> o <backspace> - <tab> w <tab> <backspace> s
a <tab> <return> M-: M-( s e q SPC <backspace> <backspace>
t q SPC b e f M-/ - M-/ SPC n i l C-e <return> C-x
C-s C-x v = M-> M-< C-x C-w C-g C-SPC M-> M-w <menu-bar>
<help-menu> <send-emacs-bug-report>

Recent messages:
Making completion list... [2 times]
Type C-x 1 to delete the help window, C-M-v to scroll help.
Scanning for dabbrevs...100% [2 times]
Saving file /Users/ieure/Projects/emacs/lisp/progmodes/sql.el...
Wrote /Users/ieure/Projects/emacs/lisp/progmodes/sql.el
Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/ sql.el...done
Mark set [2 times]
Mark set

--- End Message ---
--- Begin Message --- Subject: Re: 23.0.60; [PATCH] sql-sqlite doesn't work Date: Fri, 13 Feb 2009 22:38:20 -0500 User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Installed, given that it looks fine and two people have come up with
the same solution. (Bugs 1904, 2313).

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]