[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#2406: ewoc-collect doesn't match documentatino

From: David Kågedal
Subject: bug#2406: ewoc-collect doesn't match documentatino
Date: Fri, 20 Feb 2009 09:04:54 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Ths documentation for the ewoc-collect function says "The elements on
the returned list will appear in the same order as in the buffer", but
this is not true.

  (ewoc--set-buffer-bind-dll-let* ewoc
      ((header (ewoc--header ewoc))
       (node (ewoc--node-nth dll -2))
    (while (not (eq node header))
      (if (apply predicate (ewoc--node-data node) args)
          (push (ewoc--node-data node) result))
      (setq node (ewoc--node-prev dll node)))
    (nreverse result)))

As you can see, it goes throuth the nodes backwards and conses a list,
which will thus be in the correct order. But then it ends with a call
to nreverse that reverses the order so that the return result has the
nodes completely backwards.

Replacing "(nreverse result)" with "result" produces the expected

In GNU Emacs 22.2.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2008-09-05 on yellow, modified by Ubuntu
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
configured using `configure  '--build=x86_64-linux-gnu' 
'--host=x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' 
'--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' 
'--mandir=/usr/share/man' '--with-pop=yes' 
 '--with-x=yes' '--with-x-toolkit=athena' '--with-toolkit-scroll-bars' 
'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN 
-DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

David Kågedal

reply via email to

[Prev in Thread] Current Thread [Next in Thread]