bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4348: 23.1; bookmark-delete don't increment save counter when using


From: Thierry Volpiatto
Subject: bug#4348: 23.1; bookmark-delete don't increment save counter when using batch arg.
Date: Sat, 05 Sep 2009 08:59:44 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the address@hidden mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hi,
as the title say, bookmark-delete don't increment
`bookmark-alist-modification-count'
when using batch arg.

,----
|   (if batch
|       nil
|     (bookmark-bmenu-surreptitiously-rebuild-list)
|     (setq bookmark-alist-modification-count
|           (1+ bookmark-alist-modification-count))
|     (if (bookmark-time-to-save-p)
|         (bookmark-save))))
`----

As you can see, saving code is called only in else section.

Here the redefinition i made in bookmark+.el that fix the problem:

,----
|   (unless batch
|     (bookmark-bmenu-surreptitiously-rebuild-list))
|   (setq bookmark-alist-modification-count
|         (1+ bookmark-alist-modification-count))
|   (when (bookmark-time-to-save-p)
|     (bookmark-save)))
`----

This bug don't appear when you delete from bmenu-list because in this
case bookmark-delete is called whithout batch arg.

But that is annoying for external programs that call bookmark-delete
with batch arg (e.g anything, icicles).

NOTE:
If you make this change, you will probably want to remove unused saving
code in `bookmark-bmenu-execute-deletions'.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i686-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-07-31 on tux
Windowing system distributor `The X.Org Foundation', version 11.0.10503000
configured using `configure  '--prefix=/usr' '--build=i686-pc-linux-gnu' 
'--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' 
'--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' 
'--localstatedir=/var/lib' '--program-suffix=-emacs-23' 
'--infodir=/usr/share/info/emacs-23' '--with-sound' '--with-x' 
'--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' 
'--with-rsvg' '--with-tiff' '--with-xpm' '--with-xft' '--without-libotf' 
'--without-m17n-flt' '--with-x-toolkit=gtk' '--without-hesiod' 
'--without-kerberos' '--without-kerberos5' '--with-gpm' '--with-dbus' 
'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 
'CFLAGS=-march=i686 -pipe -O2' 'LDFLAGS=-Wl,-O1''

Important settings:
  value of $LC_ALL: fr_FR.UTF-8
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: fr_FR.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  icomplete-mode: t
  icicle-mode: t
  delete-selection-mode: t
  minibuffer-depth-indicate-mode: t
  auto-image-file-mode: t
  shell-dirtrack-mode: t
  partial-completion-mode: t
  show-paren-mode: t
  display-battery-mode: t
  display-time-mode: t
  diff-auto-refine-mode: t
  outline-minor-mode: t
  recentf-mode: t
  savehist-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> C-c SPC <f11> a <down> <down> <down> 
<down> <down> <down> <return> C-c C-g d e l e t e <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <up> 
<up> <up> <up> <return> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<up> <up> <up> <up> C-SPC C-n C-n C-n C-n C-n C-n M-w 
<up> <up> <up> <up> <right> <right> <right> <right> 
<right> <right> <right> <right> C-u C-c C-g C-g M-x 
s u b m i t <tab> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> C-g <f5> a p b 
u g g <backspace> <backspace> <backspace> <backspace> 
<backspace> e m m a a c c s s SPC b b u u g g <down> 
<return> <f11> e t d e f a <backspace> <backspace> 
<backspace> <backspace> a l i a s SPC s e n d - b u 
g - e m a c s <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
e m a c s - b u g SPC <S-up> C-x b <return> <S-down> 
r e p o r t - e m a c s - b u g <return> <f11> e t 
C-! s e n d - e <tab> <return> <down> <up> <f11> e 
t <C-up> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <return> <f11> 
e t M-x r e p o r t - e m a <tab> <down> <return>

Recent messages:
Loading em-prompt...done
Loading em-script...done
Loading em-unix...done
Saving file /home/thierry/.emacs.d/.eshell/alias...
Wrote /home/thierry/.emacs.d/.eshell/alias
usage: report-emacs-bug: (TOPIC &optional RECENT-KEYS)
History item: 128
Saving file /home/thierry/.emacs.d/.eshell/alias...
Wrote /home/thierry/.emacs.d/.eshell/alias
Computing completion candidates...

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France







reply via email to

[Prev in Thread] Current Thread [Next in Thread]