[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm

From: Juri Linkov
Subject: bug#4362: 23.1: proced -- Mode help lists 'd' as mark command (prefer 'm')
Date: Wed, 09 Sep 2009 03:57:38 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)

> M-x proced
> C-h m
>     Proced: user by -PU mode:
>     Mode for displaying UNIX system processes and sending signals to them.
>     Type M-x proced to start a Proced session.  In a Proced buffer
>>>  type d to mark a process for later commands.
>     Type x to send signals to marked processes.
> PLease prefer listing the 'm' as the mark command in the mode help
> listing. 'd' and 'm' both seem to mark lines, but for mode help, listing
> the 'm' would better follow the convention used in other buffers like buffer
> list, dired etc.
> From: Glenn Morris <address@hidden>
> To: address@hidden
> Date: Sun, 06 Sep 2009 22:35:58 -0400
>   * proced.el (proced-mode-map): Bind "d" to proced-mark-alt.
>   (proced-mark-alt): New alias, to control the advertised key.  (Bug#4362)

But now `C-h m' displays:

m               proced-mark
d               proced-mark-alt

that causes a false impression that these commands are different.

A simpler fix would be just changing the order of `d' and `m' bindings
in `proced-mode-map' like:

@@ -459,8 +459,8 @@
     (define-key km [down] 'next-line)
     (define-key km [up] 'previous-line)
     ;; marking
-    (define-key km "d" 'proced-mark) ; Dired compatibility ("delete")
     (define-key km "m" 'proced-mark)
+    (define-key km "d" 'proced-mark) ; Dired compatibility ("delete")
     (define-key km "u" 'proced-unmark)
     (define-key km "\177" 'proced-unmark-backward)
     (define-key km "M" 'proced-mark-all)

But really I don't understand why `m' should be preferred to `d'?
In Proced like in Dired, `d' flags a process for deletion, and `x'
commits the operation.  `m' is an alias for `d' because currently there
is no more dired-like operations on processes.

The only reason to prefer `m' over `d' in the documentation now is
the fact that proced-mark marks a process with the "*" character
(like dired's `m' does) instead of "D" (like dired's "d" does)
until someone comes with an idea of different operations
for `m' and `d' in Proced like in Buffer-menu where they are bound
to different commands:

  m -- mark current line's buffer to be displayed.
  d -- mark that buffer to be deleted, and move down.
  x -- delete or save marked buffers.

Juri Linkov

reply via email to

[Prev in Thread] Current Thread [Next in Thread]