bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name'


From: Emacs bug Tracking System
Subject: bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name')
Date: Sun, 13 Sep 2009 02:25:04 +0000

Your message dated Sat, 12 Sep 2009 22:17:51 -0400
with message-id <address@hidden>
and subject line Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-name'
has caused the Emacs bug report #4308,
regarding 23.1.50; patch: fix `eshell-history-file-name'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
4308: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4308
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 23.1.50; patch: fix `eshell-history-file-name' Date: Tue, 01 Sep 2009 20:32:10 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin)
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The attached small patch makes eshell-history-file-name more robust. For
example, I accidentally set eshell-directory-name to ~/.emacs.d/shell
without a trailing / and the history was written to
~/.emacs.d/shellhistory.


diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz
--- a/em-hist.el.gz
+++ b/em-hist.el.gz
@@ -86,7 +86,7 @@
   :group 'eshell-hist)
 
 (defcustom eshell-history-file-name
-  (concat eshell-directory-name "history")
+  (expand-file-name "history" eshell-directory-name)
   "*If non-nil, name of the file to read/write input history.
 See also `eshell-read-history' and `eshell-write-history'.
 If it is nil, Eshell will use the value of HISTFILE."

Diff finished.  Tue Sep  1 20:27:29 2009


Leo


--- End Message ---
--- Begin Message --- Subject: Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Date: Sat, 12 Sep 2009 22:17:51 -0400
> > The attached small patch makes eshell-history-file-name more
> > robust. For
> > example, I accidentally set eshell-directory-name to ~/.emacs.d/shell
> > without a trailing / and the history was written to
> > ~/.emacs.d/shellhistory.

> Please also fix the following places:

All fixed, thanks.

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]