bug#4451: 23.1; EOL problems with vc-diff and cygwin

[Reiner Steib]

On Fri, Sep 18 2009, Reiner Steib wrote:

> Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> I think the best solution is to change vc-coding-system-for-diff so that
>> when it takes the coding system from (with-current-buffer buf
>> buffer-file-coding-system), it ignores the EOL part of that
>> coding system.
>>
>> Does the patch below help?
>
> It does help.  Thanks.

Any reason not to commit the patch?

>> -                buffer-file-coding-system)))
>> +                    (if buffer-file-coding-system
>> +                        ;; Don't inherit the EOL part of the coding-system,
>> +                        ;; because some diff tools may choose to use
>> +                        ;; another one.
>> +                        (coding-system-base buffer-file-coding-system)))))
>
> Shouldn't the comment mention "bug#4451"?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/