bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4510: marked as done (23.1; Separate help-argument-face from downcas


From: Emacs bug Tracking System
Subject: bug#4510: marked as done (23.1; Separate help-argument-face from downcasing)
Date: Thu, 24 Sep 2009 19:30:04 +0000

Your message dated Thu, 24 Sep 2009 21:25:22 +0200
with message-id <address@hidden>
and subject line Re: bug#4510: 23.1; Separate help-argument-face from downcasing
has caused the Emacs bug report #4510,
regarding 23.1; Separate help-argument-face from downcasing
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact address@hidden
immediately.)


-- 
4510: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4510
Emacs Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: 23.1; Separate help-argument-face from downcasing Date: Mon, 21 Sep 2009 14:35:00 -0700
Emacs 22 introduced face `help-argument-name' and function
`help-default-arg-highlight'.  The Emacs 22 NEWS says this:
 
  To change the default, customize face `help-argument-name' or
  redefine the function `help-default-arg-highlight'.
 
The problem is that function `help-default-arg-highlight' couples
(a) the use of a face to highlight the arguments with (b) downcasing
the arguments.  These two should be separated, so users can highlight
without downcasing (or downcase without highlighting).
 
I, for instance, find lowercase italics (the default, starting with
Emacs 22) to be much less readable than uppercase non-italics (the
default before Emacs 22).  But I would really prefer uppercase
italics.  There is no way to get this, short of redefining the
function `help-default-arg-highlight'.
 
That should not be the only alternative for users.  Users should not
be expected to redefine basic functions in order to customize such
appearances.  And in any case, it makes no sense for the face and
the letter case to be hard-code-coupled.

This is the definition of `help-default-arg-highlight':

(defun help-default-arg-highlight (arg)
  "Default function to highlight arguments in *Help* buffers.
It returns ARG in face `help-argument-name'; ARG is also
downcased if it displays differently than the default
face (according to `face-differs-from-default-p')."
  (propertize (if (face-differs-from-default-p 'help-argument-name)
                  (downcase arg)
                arg)
              'face 'help-argument-name))
 
If face `help-argument-name' is different from the default face,
then the args are downcased. The logic should simply be to apply
the face systematically: if it is the same as the default, then
the face would have no effect. And then provide a separate option
to control upcasing/downcasing.

In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
 




--- End Message ---
--- Begin Message --- Subject: Re: bug#4510: 23.1; Separate help-argument-face from downcasing Date: Thu, 24 Sep 2009 21:25:22 +0200
I've installed the patch, defaulting `help-downcase-arguments' to nil
as per Dan's request in bug#4520.

If someone objects to the change in the default appearance of argument
names we'll know soon enough...

    Juanma

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]