[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#4642: diff from log-view somtime diffs the wrong file
From: |
Stefan Monnier |
Subject: |
bug#4642: diff from log-view somtime diffs the wrong file |
Date: |
Mon, 05 Oct 2009 09:44:59 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
> One way to fix this is to make log-view-diff not call vc-version-diff,
> but vc-diff-internal, like so:
That looks OK. But we should also either fix vc-version-diff so it
doesn't ignore its `files' argument, or otherwise remove that argument
(which will be a good opportunity to go and fix the other callers).
Stefan
> --- log-view.el.~1.60.~ 2009-10-03 03:20:50.000000000 -0700
> +++ log-view.el 2009-10-04 19:20:58.000000000 -0700
> @@ -496,11 +496,12 @@ changeset that affected the currently co
> (goto-char end)
> (log-view-msg-next)
> (setq to (log-view-current-tag))))
> - (vc-version-diff
> - (if log-view-per-file-logs
> - (list (log-view-current-file))
> - log-view-vc-fileset)
> - to fr)))
> + (vc-diff-internal
> + t (list log-view-vc-backend
> + (if log-view-per-file-logs
> + (list (log-view-current-file))
> + log-view-vc-fileset))
> + to fr)))
> (declare-function vc-diff-internal "vc"
> (async vc-fileset rev1 rev2 &optional verbose))
> OK to check in?