[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4740: 23.1; two error re-signals

From: Kevin Ryde
Subject: bug#4740: 23.1; two error re-signals
Date: Sat, 17 Oct 2009 10:18:19 +1100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Below is untested.  Of course never-executed code isn't worth the bits
its written in, but I've got no idea how to reach either spot.  I see
other similar things doing signal instead of apply -- is that right?

2009-10-16  Kevin Ryde  <address@hidden>

        * ibuffer.el (ibuffer-confirm-operation-on),
        cedet/semantic/wisent.el (wisent-parse-stream):
        Fix error re-signal, err is a pair not a list so can't use `apply'.

--- ibuffer.el.~1.117.~ 2009-10-02 10:23:54.000000000 +1000
+++ ibuffer.el  2009-10-17 10:10:46.000000000 +1100
@@ -1191,7 +1191,7 @@
                                  ;; This definitely falls in the
                                  ;; ghetto hack category...
                                  (not (string-match "too small" (cadr err)))))
-                        (apply #'signal err)
+                        (signal (car err) (cdr err))
                       (enlarge-window 3))))))
              (select-window (next-window))
              (switch-to-buffer buf)
--- wisent.el.~1.5.~    2009-10-08 11:00:26.000000000 +1100
+++ wisent.el   2009-10-16 11:27:58.000000000 +1100
@@ -232,7 +232,7 @@
                                     (error-message-string error-to-filter))
                            (message "wisent-parse-max-stack-size \
 might need to be increased"))
-                       (apply 'signal error-to-filter))))))
+                       (signal (car error-to-filter) (cdr 
     ;; Manage returned lookahead token
     (if wisent-lookahead
         (if (eq (caar la-elt) wisent-lookahead)

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' 
'--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' 
'--localstatedir=/var/lib' '--infodir=/usr/share/info' 
'--mandir=/usr/share/man' '--with-pop=yes' 
 '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 
'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]