[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4804: 23.1; bookmark-bmenu-bookmark performances

From: Stefan Monnier
Subject: bug#4804: 23.1; bookmark-bmenu-bookmark performances
Date: Sun, 25 Oct 2009 11:12:57 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

> 1) run a loop on all menu list to toggle filenames visibility.
> 2) come back to the original place and get bookmark name with
> buffer-substring
> 3) run again a loop to toggle filenames visibility back.
> That's very costly.

Agreed, it's costly, brittle, and ugly.

But your solution relies on a correspondance between
bookmark-latest-sorted-alist and the buffer's content, even though this
correspondance is nowhere enforced (i.e. future changes to the code are
likely to break it, or manual buffer modifications could also break it).

Much easier and more robust would be to put the relevant data directly
in the buffer in the form of text-properties, so it can be extracted
directly via get-text-property regardless of whether the filenames
are hidden.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]