[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4429: purecopy calls needed for :help and in menu-bar.el

From: Juri Linkov
Subject: bug#4429: purecopy calls needed for :help and in menu-bar.el
Date: Tue, 03 Nov 2009 09:29:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)

>   > >> Does anyone know a reason why one menu item in menu-bar.el
>   > >> (`separator-exit') doesn't use the standard format with `menu-item'
>   > >> like all other menu items use?
>   > >
>   > > Accident?
>   >
>   > Probably.  Fixed.
> I think that a better fix would be to purecopy '("--"), there are >60
> instances of this in GC memory right when emacs starts up.
> Maybe define a constant menu-bar-standard-separator and use that
> everywhere?

I think a constant for "--" is a good idea.

BTW, I just added a quote in 3 calls of `menu-bar-make-mm-toggle'
in menu-bar.el since this is necessary after your recent changes
in `menu-bar-make-mm-toggle'.

I hope that no code outside Emacs calls `menu-bar-make-mm-toggle'.
Otherwise, it will be broken.

Juri Linkov

reply via email to

[Prev in Thread] Current Thread [Next in Thread]