bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessaril


From: Juanma Barranquero
Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Tue, 28 Sep 2010 01:35:12 +0200

On Mon, Sep 27, 2010 at 20:47, Drew Adams <address@hidden> wrote:

> We should use `make-variable-buffer-local' with vars such as
> `dired-subdir-alist' and `dired-directory', instead of just calling
> `make-local-variable'.  Why?  Because these vars MUST be buffer local,
> and we might as well make the code clearer by pointing that out.  That
> is precisely the use case for `make-variable-buffer-local': a var that
> is necessarily buffer-local.

On the same vein, every single use of revert-buffer-function starts with

  (make-local-variable 'revert-buffer-function)
  (setq revert-buffer-function XXXXX)

or

  (set (make-local-variable 'revert-buffer-function) XXXXXX)

except the one in dired-x.el, which relies in dired-mode doing it
before. There have been at least three bugs in the past year caused by
revert-buffer-function not being automatically buffer-local.

    Juanma





reply via email to

[Prev in Thread] Current Thread [Next in Thread]