[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#6963: More usecases, patch attached

From: Juanma Barranquero
Subject: bug#6963: More usecases, patch attached
Date: Wed, 29 Sep 2010 17:43:16 +0200

On Wed, Sep 29, 2010 at 17:08, Wolfgang Schnerring <address@hidden> wrote:

> I personally consider it a bug, since everything else about "errors
> from Emacs" is already there, only the exit status is missing. And
> that really does not play nice with others.
> (That said, this is a gray area, and one could probably also just as
> well argue the opposite.)

I tend to agree with you about it being a bug, but OTOH I try to be
extremely conservative about committing changes into the release
branch, other than typos, docfixes, regression fixes and
very-obviously-correct bugfixes. That's the stated (though not always
followed) policy, and I think it's a very good one.

In this case, the patch changes the behavior of emacsclient, so even
if it fixes a bug, it could still affect users of emacsclient in
non-obvious ways (because, as you do, they could be using emacsclient
from scripts, tools, etc.). So I'd say it's best to keep this for the

> It probably makes sense to distinguish these, since they are different
> types of errors, technical ("communication with Emacs failed") vs.
> semantic ("Emacs said boo!").
> One might want to invoke something that has known error cases, which
> would benefit from being treated differently than a socket error or
> somesuch.

I agree, and it doesn't make the patch more complicate (just one more line).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]