[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7252: hexl-revert-buffer
From: |
Stefan Monnier |
Subject: |
bug#7252: hexl-revert-buffer |
Date: |
Wed, 20 Oct 2010 12:18:53 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> If I open a ZIP file with M-x hexl-find-file and then M-x revert-buffer,
> I see hexified file list generated by arc-mode, instead of raw ZIP data.
> This behavior is surprising for me and it is cumbersome to do M-x
> kill-buffer and M-x hexl-find-file each time.
> How about adding M-x hexl-revert-buffer?
No, we should tweak revert-buffer-function instead.
> + (if (eq major-mode 'hexl-mode)
Use derived-mode-p rather than looking at major-mode.
> + (let ((coding-system-for-read 'no-conversion))
> + (revert-buffer nil nil t)
> + (setq major-mode 'fundamental-mode)
Why is this setq needed (IOW please add a comment explaining why it's
needed).
Stefan