bug#7307: 24.0.50; Mode line had more than just dashes removed

[Eli Zaretskii]

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: 7307@debbugs.gnu.org
> Date: Tue, 02 Nov 2010 00:35:25 +0100
> 
> On Mon, 01 Nov 2010 21:32:12 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
> 
> >> From: Stephen Berman <stephen.berman@gmx.net>
> >> Date: Mon, 01 Nov 2010 19:11:49 +0100
> >> Cc: 7307@debbugs.gnu.org
> >> 
> >> +  mode_line_filler = !NILP (Fwindow_system (Qnil)) ? lots_of_spaces 
> >> +    : lots_of_dashes;
> >
> > Actually, you want to use `FRAME_WINDOW_P (f)' here.  It does exactly
> > what you mean, but with much smaller overhead (for starters, it
> > doesn't call Lisp).
> 
> Thanks. (I copied Fwindow_system, with the accompanying "This is wrong"
> comment, from keyboard.c; I wonder why `FRAME_WINDOW_P (f)' isn't used
> there.)

Indeed.  Chong, this is your change:

  2010-08-31  Chong Yidong  <cyd@stupidchicken.com>

         * keyboard.c (command_loop_1): Don't call x-set-selection on tty.


Can you tell why you didn't use FRAME_WINDOW_P?  Am I missing some
subtlety?