[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#8415: 23.3.50; Extensible Emacs Registers

From: Stefan Monnier
Subject: bug#8415: 23.3.50; Extensible Emacs Registers
Date: Sat, 25 Jun 2011 09:19:50 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> Is this patch OK?

Looks OK, yes.

> +     (jump-func (funcall jump-func (registerv-data val)))

But I'd pass `val' directly, so the function can use extra fields in
values that inherit from registerv.  You could drop the `data' field as
well, at that point.

This just makes it more OO, and maybe experience would show that it
actually makes things worse (just adds unused extra flexibility), so
I'll let you judge.  Either way is OK with me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]