[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#6693: 24.0.50; font-lock-(builtin|doc) faces are *way* too close

From: Drew Adams
Subject: bug#6693: 24.0.50; font-lock-(builtin|doc) faces are *way* too close
Date: Mon, 4 Jul 2011 09:12:16 -0700

> > `font-lock-builtin-face' (":type", ":group")
> > `font-lock-doc-face'     (the doc strings)
> > `font-lock-keyword-face' ("defcustom")
> >
> > But especially the first two of these are close.
> Hmm. Looking at your screenshot reminded me: but then what about 
> font-lock-comment-face (Firebrick)? Do you also see it as a bit too 
> close to font-lock-doc-face (VioletRed4), but from the other 
> direction (on the hue wheel)?

All three of these are close: 


However, I personally am not bothered by those similarities.

Again, personally I see font-lock mostly with Emacs-Lisp code, so I might not be
the best one to ask.

There is almost never any problem confusing a comment with a string (in Emacs
Lisp).  I suppose that a string and a comment on the same line might be
confusable, but in practice I don't think there is a problem here (worth trying
to fix, possibly messing up other things).

Similarly, I don't see a significant problem from the similarity between
`font-lock-variable-name-face' and the others, because of context.

Yidong makes the argument (essentially) that we should not take context into
consideration, since faces can inherit from the font-lock faces.  IMHO, that is
rather a problem with inheriting faces (esp. inheriting willy nilly), but we've
been through that discussion before and I know that I will not be able to
convince you (pl.) about that.

Wrt `font-lock-builtin-face', I say go for it: make some change and see what
happens.  My guess is that medium blue would be better than royal blue, but do
what you think is best.

I'm pretty much done here.  I mainly wanted to draw your attention to the
problem, reporting the color similarity for built-in and doc (and my personal
preference for the previous situation (Orchid)).  Fix the problem as you see
fit, and we'll see then whether anyone has a better approach etc.

I should probably have said that a second problem I have with the MediumViolet4
choice for the builtin face is that it does not stand out from black - IOW, it
is not sufficiently noticeable, for keywords.  That's no doubt another reason
why I preferred Orchid, and a reason why my argument about differing contexts
doesn't mitigate the problem here.

In sum (for the second problem): builtin doesn't stand out enough, and I don't
(personally) care whether it is "too light" (e.g. Orchid).  What's important for
something like keywords is that they stand out.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]