[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9781: 24.0.90; VC can't commit removed files/directories.

From: Glenn Morris
Subject: bug#9781: 24.0.90; VC can't commit removed files/directories.
Date: Thu, 20 Oct 2011 17:05:21 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Jan Djärv wrote:

> In a bzr repository, do
> % bzr rm some-file
> and modify some other file.
> Then in Emacs, do vc-dir on the directory where the file was.
> Mark the file that is listed as removed.  Also mark the edited file.
> Press v.
> Expected result: I can type in a log message and commit.
> Real result: A prompt in the minibuffer appears:
> some-file is edited but read-only; make it writable and continue? (y/n) 

Fixed. Now you will be able to commit (and then get bug#3214).

Actually the problem only happens with removed directories (because
file-writable-p also returns non-nil if a file can be created).

mkdir /tmp/foo
cd /tmp/foo
bzr init
mkdir subdir
touch file subdir/subfile
bzr add
bzr commit -m "c1"
bzr remove subdir
echo 1 >> file
emacs -Q
M-x vc-dir RET

> Also, the choices in the question should be three:
> 1 Make writable and continue.
> 2 Don't make writable and continue
> 3 Abort

Isn't ctrl-g good enough for aborting, rather than introducing a 3-state

reply via email to

[Prev in Thread] Current Thread [Next in Thread]