[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9853: 24.0.90; gdb-version only set in non-stop mode

From: Ken Brown
Subject: bug#9853: 24.0.90; gdb-version only set in non-stop mode
Date: Wed, 26 Oct 2011 14:04:17 -0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

On 10/23/2011 6:33 PM, Ken Brown wrote:
The variable gdb-version is set in the function gdb-non-stop-handler,
which is only called if gdb-non-stop is non-nil. Given that
gdb-non-stop-setting is customizable and may well be set to nil,
wouldn't it make more sense to get the version some other way? For
instance, there's a GDB/MI command -gdb-version that could be used.

After looking through gdb-mi.el more carefully, I see that emacs doesn't really need to know the GDB version. So I withdraw my complaint. But I think the variable gdb-version should probably be renamed to reflect its real purpose, perhaps to gdb-supports-non-stop.

Also, the -enable-pretty-printing command is sent from
gdb-non-stop-handler and so is only sent if gdb-non-stop is non-nil.

This still seems wrong, unless there's some reason that pretty-printing is only useful in non-stop mode.

The attached patch implements my suggestions (and also makes a couple of whitespace changes).

OK to apply?


Attachment: gdb-version.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]