[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#2224: [PATCH] add-log.el: Modularize add-log-current-defun, new type
bug#2224: [PATCH] add-log.el: Modularize add-log-current-defun, new types supported
Thu, 12 Apr 2012 14:11:47 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)
>>>> (add-log-current-defun-type-shell-bourne-like): New function.
>>>> (add-log-current-defun-type-makefile-like): New function.
>>>> (add-log-current-defun-type-text-asciidoc-like): New function.
>>>> (add-log-current-defun-type-default): New function.
>> Having them be separate functions is indeed very good. But most of them
>> shouldn't be in add-log.el: they should be in their respective
>> major-mode instead.
> and stuff? Doesn't that seem kinda... I don't know. Error-prone?
I thought you were going to say "Obvious?".
Think about it: why should add-log support be different than say,
font-lock, outline, imenu, younameit? Oh and BTW, this same function
can/should be used for which-func-mode.
Of course in js.el it shouldn't be called
something like that.
> Because add-log (in the patch) has a major cond up there that will call
> the functions unconditionally if there's a match with the mode (and
> other things), so there's potential for things getting out of sync if
> people are using different versions of (say) js.el that doesn't define
> the function in question...
We had the same problem when we moved the font-lock defs away from
font-lock.el. Yes, it's a problem. No, it's not insurmountable.