[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9642: closed (Re: bug#9642: move-overlay creates an empty overlay wi
bug#9642: closed (Re: bug#9642: move-overlay creates an empty overlay with the evaporate property)
Mon, 14 May 2012 01:46:33 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
> I ran into this and I think I got my head around the problem with
> revision 108012.
Thanks, your analysis sounds right and your patch looks OK.
Could you please send an updated patch with the following nitpicks
- Add a space before the opening paren of function calls.
- Use two spaces to end sentences in comments.
- Don't forget to punctuate your comments.
> + /* Make notice of original overlay values */
E.g. here, add ". " after "values".
> + return unbind_to(count, Fdelete_overlay (overlay));
and here add a space after "unbind_to".
[ Of course, I could do it myself, but we can't install your patch right
now anyway because that's going beyond what we consider as "tiny patch"
so we need your copyright paperwork first. ]
- bug#9642: closed (Re: bug#9642: move-overlay creates an empty overlay with the evaporate property),
Stefan Monnier <=