[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive wit
|
From: |
Ari Roponen |
|
Subject: |
bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text |
|
Date: |
Tue, 15 May 2012 13:07:08 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>
> But since the fix is quite simple, here you go: fixed in revision
> 107994 on the emacs-24 branch.
>
Thank you. I can still reproduce the bug with that revision, but the
following tweak seems to help. I'm not sure if it is correct, but at
least it fixes the testcase, and everything else seems to work okay.
=== modified file 'src/xdisp.c'
--- src/xdisp.c 2012-05-13 18:22:35 +0000
+++ src/xdisp.c 2012-05-15 09:51:45 +0000
@@ -1313,7 +1313,7 @@
visible_p = bottom_y > window_top_y;
else if (top_y < it.last_visible_y)
visible_p = 1;
- if (bottom_y >= it.last_visible_y
+ if (bottom_y <= it.last_visible_y
&& it.bidi_p && it.bidi_it.scan_dir == -1
&& IT_CHARPOS (it) < charpos)
{
--
Ari Roponen
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Ari Roponen, 2012/05/13
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/13
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text,
Ari Roponen <=
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/15
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Ari Roponen, 2012/05/16
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/16
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Ari Roponen, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Ari Roponen, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Michael Welsh Duggan, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Michael Welsh Duggan, 2012/05/17
- bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text, Eli Zaretskii, 2012/05/18